Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the featured packages audit-helper -> DPE #2315

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

b-per
Copy link
Contributor

@b-per b-per commented Feb 24, 2023

Updating the featured packages to reflect some of the dbt-labs repos with higher star counts.

🎩

Before

image

After

image

@dbeatty10
Copy link
Contributor

Nice @b-per -- thanks for instigating a review of the featured packages!

Problem to solve

Something that came up that I'd like to solve...

In my browser, it's rending like this by default:
image

If I zoom out one level, it has much nicer rendering and gets them all on one row:
image

It's not all about me -- but if I'm running into it, I can only assume others will also.

Some ideas

  1. Live with it or buy a larger monitor
  2. Adjust the CSS (or whatever) to make the font smaller by default, so it can fit on one row
  3. Add audit helper as a 4th item on the list, so it will display a 2X2 grid for display sizes like mine
  4. Rename dbt_project_evaluator so that it is 12 characters or less (okay, just kidding about this one)

It seems like Idea 1 is the way to go, but open to a wide variety of ideas of how to solve this. What do you think?

@github-actions github-actions bot force-pushed the update-featured-packages branch 3 times, most recently from 39de47d to 691235d Compare May 17, 2023 23:03
@github-actions github-actions bot force-pushed the update-featured-packages branch from 691235d to 563980e Compare June 5, 2023 22:55
@github-actions github-actions bot force-pushed the update-featured-packages branch from 563980e to 912ef8c Compare June 23, 2023 23:28
@github-actions github-actions bot force-pushed the update-featured-packages branch from 912ef8c to 1c3d0f1 Compare September 6, 2023 14:17
@vercel
Copy link

vercel bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 2:34pm

@b-per
Copy link
Contributor Author

b-per commented Sep 22, 2023

@dbeatty10 reviving this one!

I added another row of 3 featured packages, having a total of 6 now! This number feels reasonable to me knowing the high number of packages now available on the hub.

I have also slightly updated the style of the cards:

  • I removed the "dbt models for ..." which seemed irrelevant for most packages as they don't contain models but macros
  • I made the icon and the text smaller

Let me know what you think!!!

Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing @b-per 👑

@dbeatty10 dbeatty10 merged commit 94b1fb7 into master Sep 22, 2023
@dbeatty10 dbeatty10 deleted the update-featured-packages branch September 22, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants